Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend hydrateCache request type #6329

Merged
merged 7 commits into from
Aug 14, 2023
Merged

Conversation

tnorling
Copy link
Collaborator

Adds SsoSilentRequest, PopupRequest, and RedirectRequest to hydrateCache request type

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Aug 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #6329 (ecc5965) into dev (81d34b4) will increase coverage by 1.65%.
Report is 253 commits behind head on dev.
The diff coverage is 92.78%.

Flag Coverage Δ
msal-angular 96.73% <92.78%> (+0.22%) ⬆️
msal-browser 85.53% <ø> (-0.94%) ⬇️
msal-common ?
msal-core ?
msal-node ?
msal-node-extensions ?
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Changed Coverage Δ
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
...b/msal-browser/src/app/IPublicClientApplication.ts 42.42% <ø> (-1.33%) ⬇️
...ib/msal-browser/src/app/PublicClientApplication.ts 67.44% <ø> (-27.89%) ⬇️
...er/src/broker/nativeBroker/NativeMessageHandler.ts 86.29% <ø> (+0.33%) ⬆️
lib/msal-browser/src/cache/AsyncMemoryStorage.ts 80.76% <ø> (+2.99%) ⬆️
... and 55 more

... and 168 files with indirect coverage changes

Copy link
Contributor

@peterzenz peterzenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@tnorling
Copy link
Collaborator Author

Tests?

No functional changes, just type additions, the test is the TypeScript transpiler

@tnorling tnorling merged commit 739f260 into dev Aug 14, 2023
@tnorling tnorling deleted the extend-hydrateCache-request-type branch August 14, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants