Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New API to clear cache #6374

Merged
merged 10 commits into from
Aug 29, 2023
Merged

New API to clear cache #6374

merged 10 commits into from
Aug 29, 2023

Conversation

lalimasharda
Copy link
Contributor

@lalimasharda lalimasharda commented Aug 18, 2023 •
edited

New SilentCacheClient API to clear cache silently using the clearCacheOnLogout() method.

@lalimasharda lalimasharda changed the title new API to clear cache New API to clear cache Aug 18, 2023
@github-actions github-actions bot added the msal-browser Related to msal-browser package label Aug 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023 •
edited

Codecov Report

Merging #6374 (cec79a2) into dev (81d34b4) will increase coverage by 1.90%.
Report is 276 commits behind head on dev.
The diff coverage is 92.78%.

Flag Coverage Δ
msal-angular 96.73% <92.78%> (+0.22%) ⬆️
msal-browser 85.78% <ø> (-0.69%) ⬇️
msal-common ?
msal-core ?
msal-node ?
msal-node-extensions ?
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Changed Coverage Δ
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
...b/msal-browser/src/app/IPublicClientApplication.ts 41.17% <ø> (-2.58%) ⬇️
...ib/msal-browser/src/app/PublicClientApplication.ts 65.90% <ø> (-29.42%) ⬇️
...er/src/broker/nativeBroker/NativeMessageHandler.ts 86.29% <ø> (+0.33%) ⬆️
lib/msal-browser/src/cache/AsyncMemoryStorage.ts 80.76% <ø> (+2.99%) ⬆️
... and 50 more

... and 172 files with indirect coverage changes

@lalimasharda lalimasharda marked this pull request as ready for review August 19, 2023 00:05
sameerag
sameerag reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some description please?

sameerag
sameerag approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I think we can get rid of the silentCache class later, for now this works.

@lalimasharda lalimasharda merged commit eba1c90 into dev Aug 29, 2023
28 of 29 checks passed
@lalimasharda lalimasharda deleted the new_cache_clear_API branch August 29, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lalimasharda @codecov-commenter @tnorling @sameerag