-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper functions for telemetry & logging #6383
Conversation
…tion-library-for-js into wrap-with-telem-logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us track the user experience with a separate PR, approving as is. This is great improvement over redundant code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a nice readability and maintenance improvement. Thanks.
@@ -74,11 +75,6 @@ export class SilentIframeClient extends StandardInteractionClient { | |||
PerformanceEvents.SilentIframeClientAcquireToken, | |||
request.correlationId | |||
); | |||
this.logger.verbose("acquireTokenByIframe called"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to remove this logger line as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the invoke functions will handle logging start/end messages as well
invoke
andinvokeAsync
helper functions to wrap APIs with telemetry measurements and trace logging.httpVerToken
andrefreshTokenSize
to more central place right after POSThttpVerAuthority
is it represents the same thing ashttpVerToken
but with a different namePros
Cons