Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make eventName of type string for BrowserPerformanceClient and PerformanceClient #6386

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Make eventName of type string for BrowserPerformanceClient and PerformanceClient #6386

merged 2 commits into from
Aug 24, 2023

Conversation

konstantin-msft
Copy link
Collaborator

@konstantin-msft konstantin-msft commented Aug 24, 2023 •
edited

  • Make eventName of type string for BrowserPerformanceClient and PerformanceClient.
  • Expose InProgressPerformanceEvent to get rid of msal-common dep in 1p.

@konstantin-msft
- Make eventName of type string for BrowserPerformanceClient and …
781bea8 
…`PerformanceClient`.

- Expose `InProgressPerformanceEvent`.
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Aug 24, 2023
@konstantin-msft konstantin-msft marked this pull request as ready for review August 24, 2023 15:06
peterzenz
peterzenz approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@peterzenz peterzenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test impact?

@konstantin-msft
Copy link
Collaborator Author

Any test impact?

No functional changes. Just updating types to enable 1p compilation without msal-common.

@konstantin-msft konstantin-msft merged commit 5d05054 into dev Aug 24, 2023
48 checks passed
@konstantin-msft konstantin-msft deleted the update_telemetry_types branch August 24, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@peterzenz peterzenz peterzenz approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@konstantin-msft @tnorling @peterzenz