Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declass encoder/decoder for reduced size #6416

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Conversation

tnorling
Copy link
Collaborator

  • Moves Base64Encoder and Base64Decoder into functions rather than class methods
  • Updates their implementations to use built-in browser APIs (now available since we don't support IE anymore!)

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #6416 (163ba8e) into dev (81d34b4) will increase coverage by 1.37%.
Report is 286 commits behind head on dev.
The diff coverage is n/a.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 85.16% <ø> (-1.31%) ⬇️
msal-common ?
msal-core ?
msal-node ?
msal-node-extensions ?
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Changed Coverage Δ
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
...b/msal-browser/src/app/IPublicClientApplication.ts 41.17% <ø> (-2.58%) ⬇️
... and 42 more

... and 180 files with indirect coverage changes

…8.json

Co-authored-by: Sameera Gajjarapu <sameera.gajjarapu@microsoft.com>
@tnorling tnorling merged commit 2ef47fe into dev Sep 1, 2023
29 checks passed
@tnorling tnorling deleted the declass-encoder-decoder branch September 1, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants