-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declass encoder/decoder for reduced size #6416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tnorling
commented
Aug 31, 2023
- Moves Base64Encoder and Base64Decoder into functions rather than class methods
- Updates their implementations to use built-in browser APIs (now available since we don't support IE anymore!)
tnorling
requested review from
sameerag,
hectormmg,
jo-arroyo,
peterzenz,
konstantin-msft,
lalimasharda,
bgavrilMS and
Robbie-Microsoft
as code owners
August 31, 2023 18:56
sameerag
reviewed
Aug 31, 2023
change/@azure-msal-browser-a12bca4f-39ee-49e6-bd21-5e6af072d408.json
Outdated
Show resolved
Hide resolved
…8.json Co-authored-by: Sameera Gajjarapu <sameera.gajjarapu@microsoft.com>
peterzenz
approved these changes
Sep 1, 2023
lalimasharda
approved these changes
Sep 1, 2023
…tion-library-for-js into declass-encoder-decoder
…microsoft-authentication-library-for-js into declass-encoder-decoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.