Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter rule to avoid floating promises #6421

Merged
merged 18 commits into from
Sep 5, 2023
Merged

Add linter rule to avoid floating promises #6421

merged 18 commits into from
Sep 5, 2023

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented Sep 1, 2023

Adding a linter rule to avoid floating promises: no-floating-promises

Note: Thanks @peterzenz for spotting this and @konstantin-msft for the linter tip.

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Sep 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #6421 (b61203f) into dev (81d34b4) will decrease coverage by 2.06%.
Report is 289 commits behind head on dev.
The diff coverage is 61.03%.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 85.24% <ø> (-1.23%) ⬇️
msal-common 82.85% <ø> (-1.70%) ⬇️
msal-core ?
msal-node 80.01% <ø> (-3.38%) ⬇️
msal-node-extensions 68.51% <60.77%> (-7.13%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Changed Coverage Δ
...ions/msal-node-extensions/src/utils/Environment.ts 20.51% <0.00%> (-22.08%) ⬇️
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
... and 55 more

... and 178 files with indirect coverage changes

@github-actions github-actions bot added the msal-common Related to msal-common package label Sep 1, 2023
@sameerag sameerag changed the title Add a missing await in the controller flow Add linter rule to avoid floating promises Sep 1, 2023
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-node Related to msal-node package msal-react Related to @azure/msal-react labels Sep 1, 2023
@sameerag sameerag merged commit a5a93f9 into dev Sep 5, 2023
43 checks passed
@sameerag sameerag deleted the controller-await branch September 5, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package msal-react Related to @azure/msal-react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants