Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declass AuthToken to reduce size #6423

Merged
merged 10 commits into from
Sep 5, 2023
Merged

Declass AuthToken to reduce size #6423

merged 10 commits into from
Sep 5, 2023

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Sep 1, 2023

Converts AuthToken class into individual functions to help with minification

@github-actions github-actions bot added msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package labels Sep 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023 •
edited

Codecov Report

Merging #6423 (6cd675a) into dev (81d34b4) will decrease coverage by 2.00%.
Report is 290 commits behind head on dev.
The diff coverage is 61.03%.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 85.20% <ø> (-1.27%) ⬇️
msal-common ?
msal-core ?
msal-node 80.16% <ø> (-3.23%) ⬇️
msal-node-extensions 68.51% <60.77%> (-7.13%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Changed Coverage Δ
...ions/msal-node-extensions/src/utils/Environment.ts 20.51% <0.00%> (-22.08%) ⬇️
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
... and 56 more

... and 179 files with indirect coverage changes

@tnorling tnorling enabled auto-merge (squash) September 5, 2023 17:58
@tnorling tnorling merged commit 72e3963 into dev Sep 5, 2023
42 of 43 checks passed
@tnorling tnorling deleted the declass-AuthToken branch September 5, 2023 18:17
@ngbrown ngbrown mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameerag sameerag sameerag approved these changes

@konstantin-msft konstantin-msft konstantin-msft approved these changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@trwalke trwalke Awaiting requested review from trwalke trwalke is a code owner

@pmaytak pmaytak Awaiting requested review from pmaytak pmaytak is a code owner

@gladjohn gladjohn Awaiting requested review from gladjohn gladjohn is a code owner

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava neha-bhargava is a code owner

@rayluo rayluo Awaiting requested review from rayluo rayluo is a code owner

@Avery-Dunn Avery-Dunn Awaiting requested review from Avery-Dunn Avery-Dunn is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tnorling @codecov-commenter @sameerag @konstantin-msft