Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear claims when config is set to not cache them #6430

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented Sep 5, 2023

Dev port for #6356

@sameerag sameerag marked this pull request as ready for review September 5, 2023 19:51
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Sep 5, 2023
@sameerag sameerag marked this pull request as draft September 5, 2023 19:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #6430 (fe8e5db) into dev (81d34b4) will decrease coverage by 3.97%.
Report is 292 commits behind head on dev.
The diff coverage is 18.96%.

Flag Coverage Δ *Carryforward flag
msal-angular 96.73% <ø> (+0.22%) ⬆️ Carriedforward from 22b7113
msal-browser 85.32% <ø> (-1.15%) ⬇️ Carriedforward from 22b7113
msal-common 82.83% <ø> (-1.72%) ⬇️
msal-core ?
msal-node 80.16% <ø> (-3.23%) ⬇️
msal-node-extensions 40.61% <18.96%> (-35.03%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ions/msal-node-extensions/src/utils/Environment.ts 20.51% <0.00%> (-22.08%) ⬇️
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
... and 49 more

... and 184 files with indirect coverage changes

@sameerag sameerag marked this pull request as ready for review September 5, 2023 21:25
Co-authored-by: Thomas Norling <thomas.norling@microsoft.com>
@sameerag sameerag enabled auto-merge (squash) September 5, 2023 22:02
@sameerag sameerag merged commit dc5ec8d into dev Sep 5, 2023
38 of 43 checks passed
@sameerag sameerag deleted the claims-clearance-dev branch September 5, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants