MSAL JS should not throw user account switch error when home account ids of the request/response match #6846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalimasharda
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz and
konstantin-msft
as code owners
sameerag
reviewed
Jan 25, 2024
|
|
||
| if ( | ||
| homeAccountIdentifier != cachedhomeAccountId && | ||
| response.account.id !== request.accountId |
There was a problem hiding this comment.
Can we add the use cases in description of this PR where this is true that is, home account ID matches but account response differs and vice versa? I thought this was added to address the difference between embedded frame vs the parent frame in the request and am curious where this bug surfaced?
There was a problem hiding this comment.
Yep that's the main use case. Also, parent's native account id seemed to be getting passed on to the embeddd frame, so I have included a fix for that in this PR as well.
tnorling
reviewed
Feb 6, 2024
…tion-library-for-js into native_account_switch_error
tnorling
reviewed
Feb 7, 2024
lib/msal-browser/src/interaction_client/NativeInteractionClient.ts
Outdated
Show resolved
Hide resolved
tnorling
approved these changes
Feb 7, 2024
…t.ts Co-authored-by: Thomas Norling <thomas.norling@microsoft.com>
hectormmg
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues: