Remove invalid prompt for silent request instead of throwing an error #6895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantin-msft
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo and
peterzenz
as code owners
tnorling
reviewed
Feb 14, 2024
| ); | ||
| delete request.prompt; |
There was a problem hiding this comment.
Objects are passed by reference so this can have unintended effects elsewhere - I suggest removing this and changing the logic below to prompt: request.prompt === PromptValue.NO_SESSION ? PromptValue.NO_SESSION : PromptValue.NONE
There was a problem hiding this comment.
Alternatively you can spread the input object into a new object at the top of the function and then manipulate the new one as you wish
There was a problem hiding this comment.
Good point. Fixed
tnorling
reviewed
Feb 14, 2024
| if ( | ||
| request.prompt && | ||
| request.prompt !== PromptValue.NONE && | ||
| request.prompt !== PromptValue.NO_SESSION | ||
| ) { | ||
| throw createBrowserAuthError( | ||
| BrowserAuthErrorCodes.silentPromptValueError | ||
| this.logger.verbose( |
There was a problem hiding this comment.
A higher log level seems appropriate here
Suggested change
| this.logger.verbose( | |
| this.logger.warning( |
konstantin-msft
force-pushed
the
iframe_enforce_silent_prompt
branch
from
0a35206 to
2ab4829
Compare
tnorling
approved these changes
Feb 14, 2024
hectormmg
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when request prompt bleeds from msal-react MsalAuthenticationTemplate into ATS silentIframeClient.