Clean up BroadcastChannel resources to fix hanging tests #8045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses hanging test issues by implementing proper cleanup of BroadcastChannel resources in the test environment. The changes introduce a tracking mechanism for BroadcastChannel instances to ensure they are properly closed after tests complete.
- Implements a BroadcastChannel tracking system to monitor active instances
- Adds automatic cleanup hooks in test environments to prevent resource leaks
- Removes the
--forceExitflag from Jest configuration since proper cleanup eliminates the need to force test termination
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shared-configs/jest-config/setupGlobals.cjs | Integrates BroadcastChannel tracker and replaces global BroadcastChannel with tracked version |
| shared-configs/jest-config/BroadcastChannelTracker.js | Creates shared tracking utility with cleanup functions for different test environments |
| lib/msal-browser/test/utils/BridgeSetup.ts | Adds cleanup hooks using global cleanup functions in afterEach/afterAll |
| lib/msal-browser/test/app/PCANonBrowser.spec.ts | Implements local BroadcastChannel tracking for Node.js environment tests |
| lib/msal-browser/package.json | Removes --forceExit flag from Jest test command |
| change/@azure-msal-browser-cc7b4b74-d9b1-4614-ab89-ac8dfb792a3f.json | Beachball change file documenting the patch |
peterzenz
approved these changes
Sep 11, 2025
tnorling
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up BroadcastChannel resources to fix hanging tests