Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak to b37ad3c; install libstp_stub.so when STP_STUB=1 #278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcumming
Copy link

Hello,

I'm updating the NixOS metadata to use bsc 103357f.

To get everything running, I needed to make a small patch to src/vendor/stp/Makefile to copy libstp_stub.so to inst/lib/SAT.

It would be great to be able to upstream this patch so we don't need to carry it anymore in the nixpkgs repo. The rest of the nix metadata changes are in jcumming/nixpkgs@442d1ae.

There are still 13 failures in bsc-testsuite (without SystemC), but those mostly seem to be NixOS-isms (like /bin/echo not existing).

@quark17
Copy link
Collaborator

quark17 commented Feb 13, 2021

This is a good catch, thanks. I've been meaning to test building with STP_STUB=1 on macOS, to see whether a similar change is needed in that case, too.

My feeling is that we might want to do one of two things: (A) Remove SNAME and install lib/*, so that the makefile installs whatever files were created, or (B) rename SNAME to INSTALLNAMES and make sure that we populate it properly with the names for all combinations of OSes and stub or no stub.

Also, if you've discovered that there are tools that the testsuite requires (such as echo) that are not mentioned in the README but are worth documenting, feel free to contribute that.

Base automatically changed from master to main March 16, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants