Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateComparator filter is broken #36

Open
rmcgurrin opened this issue Oct 7, 2015 · 2 comments
Open

StateComparator filter is broken #36

rmcgurrin opened this issue Oct 7, 2015 · 2 comments

Comments

@rmcgurrin
Copy link
Contributor

The StateFilter code is still using the "childFilter" architecture that is not valid anymore. There is corresponding fix needed in the experiment GUI: BBN-Q/PyQLab#70
rmcgurrin added a commit to rmcgurrin/Qlab that referenced this issue Oct 7, 2015
@rmcgurrin
fix BBN-Q#36
de24f43 
remove childFilter from StateComparator class and use default methods for
accumulate and get_var

modify AlizarATS9870 driver to handle the edge case when the number of records
per round robin is equal to the guessed number of records per buffer
@rmcgurrin
Copy link
Contributor Author

Corresponding PyQlab fix is in:
BBN-Q/PyQLab@6a7e49e

blakejohnson added a commit that referenced this issue Oct 7, 2015
@blakejohnson
Merge pull request #38 from rmcgurrin/fix36
66ec215 
fix #36
@rmcgurrin
Copy link
Contributor Author

fixed in 66ec215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmcgurrin