Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support APS proposal & ESAF systems to provide useful metadata #334

Merged
merged 49 commits into from
Jul 11, 2020

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Jun 26, 2020

fixes #333

@prjemian prjemian added this to the 1.3.0 milestone Jun 26, 2020
@prjemian prjemian self-assigned this Jun 26, 2020
@prjemian
Copy link
Contributor Author

static code review: B - improvements suggested

@lgtm-com
Copy link

lgtm-com bot commented Jun 26, 2020

This pull request introduces 5 alerts when merging b73e1a5 into 13444a1 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for Variable defined multiple times
  • 1 for Unused local variable

@prjemian
Copy link
Contributor Author

prjemian commented Jul 6, 2020

time to merge new content in master to this branch (Codacy review should improve)

@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2020

This pull request introduces 2 alerts when merging f544e8d into 9604f1a - view on LGTM.com

new alerts:

  • 2 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2020

This pull request introduces 2 alerts when merging 62b25fa into c9c9dc8 - view on LGTM.com

new alerts:

  • 2 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2020

This pull request introduces 2 alerts and fixes 2 when merging 27e7595 into c9c9dc8 - view on LGTM.com

new alerts:

  • 2 for Variable defined multiple times

fixed alerts:

  • 2 for Missing call to __init__ during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2020

This pull request fixes 2 alerts when merging 4d25731 into c9c9dc8 - view on LGTM.com

fixed alerts:

  • 2 for Missing call to __init__ during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2020

This pull request fixes 2 alerts when merging 83cacfd into c9c9dc8 - view on LGTM.com

fixed alerts:

  • 2 for Missing call to __init__ during object initialization

@prjemian
Copy link
Contributor Author

prjemian commented Jul 7, 2020

Success with travis-ci again and py38.

@prjemian prjemian marked this pull request as ready for review July 11, 2020 20:27
Copy link
Contributor Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 4
           

Complexity increasing per file
==============================
- apstools/beamtime/apsbss.py  15
- apstools/beamtime/apsbss_ophyd.py  1
- tests/test_beamtime.py  7
- apstools/plans.py  1
- apstools/beamtime/apsbss_makedb.py  8
         

See the complete overview on Codacy

@prjemian prjemian merged commit 63bedcc into master Jul 11, 2020
@prjemian prjemian deleted the 333-metadata-proposal-ESAF branch July 11, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

access APS proposal and ESAF information
1 participant