-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment_Engine: Added ElementsInSpace and dependant IsContaining methods / optimisations #3195
Environment_Engine: Added ElementsInSpace and dependant IsContaining methods / optimisations #3195
Conversation
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following discussion with @enarhi and @vietle-bh just now:
- This PR to be accepted as is with formatting changes suggested - and the whitespace at the bottom of
IsContaining.cs
to be removed too please @enarhi - New issue to refactor
IsContaining
from aList<Panel>
to aList<ICurve>
- New issue to then refactor
IsContaining
out from Environment_Engine and into Spatial_Engine - New issue to then refactor Environment_Engine methods to utilise Spatial_Engine methods as appropriate
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@enarhi to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now following our chat earlier, thanks @enarhi
@enarhi can I leave raising the subsequent issues with you? |
Yes, I'll add those. |
Tack så mycket 👍 |
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@enarhi to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Issues addressed by this PR
Closes #3194
Added ElementsInSpace for Element0D (1D/2D to follow as a latter PR). Also added IsContaining method for Element0D as well as faster method for detecting list of points' containment in a single space.
Test files
Test Script
Test by checking that the method correctly identifies the elements in each space as per the different visualization output options in dark blue to the script's far right.