Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Added ElementsInSpace and dependant IsContaining methods / optimisations #3195

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Oct 18, 2023

Issues addressed by this PR

Closes #3194

Added ElementsInSpace for Element0D (1D/2D to follow as a latter PR). Also added IsContaining method for Element0D as well as faster method for detecting list of points' containment in a single space.

Test files

Test Script

Test by checking that the method correctly identifies the elements in each space as per the different visualization output options in dark blue to the script's far right.

@enarhi
Copy link
Member Author

enarhi commented Oct 20, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following discussion with @enarhi and @vietle-bh just now:

  • This PR to be accepted as is with formatting changes suggested - and the whitespace at the bottom of IsContaining.cs to be removed too please @enarhi
  • New issue to refactor IsContaining from a List<Panel> to a List<ICurve>
  • New issue to then refactor IsContaining out from Environment_Engine and into Spatial_Engine
  • New issue to then refactor Environment_Engine methods to utilise Spatial_Engine methods as appropriate

Environment_Engine/Compute/ElementsInSpace.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsContaining.cs Show resolved Hide resolved
Lighting_Engine/Query/Geometry.cs Outdated Show resolved Hide resolved
@enarhi
Copy link
Member Author

enarhi commented Oct 25, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member Author

enarhi commented Oct 25, 2023

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@enarhi to confirm, the following actions are now queued:

  • check versioning

There are 6 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title Environment_Engine: Added ElementsInSpace and dependant IsContaining methods / optimizations Environment_Engine: Added ElementsInSpace and dependant IsContaining methods / optimisations Oct 25, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now following our chat earlier, thanks @enarhi

@FraserGreenroyd
Copy link
Contributor

@enarhi can I leave raising the subsequent issues with you?

@enarhi
Copy link
Member Author

enarhi commented Oct 25, 2023

@enarhi can I leave raising the subsequent issues with you?

Yes, I'll add those.

@FraserGreenroyd
Copy link
Contributor

@enarhi can I leave raising the subsequent issues with you?

Yes, I'll add those.

Tack så mycket 👍

@enarhi enarhi self-assigned this Oct 25, 2023
@enarhi enarhi added the type:feature New capability or enhancement label Oct 25, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@enarhi
Copy link
Member Author

enarhi commented Oct 25, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member Author

enarhi commented Oct 25, 2023

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 851d1ac into develop Oct 25, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#3194-ElementIsContaining branch October 25, 2023 20:09
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Add Element IsContaining Methods
3 participants