Environment_Engine: Refactor of IsContaining and ElementsInSpace methods to Geometry and Analytical namespaces as appropriate

[enarhi]

Issues addressed by this PR

Closes #3198 and #3199

Methods for IsContaining were added to Geometry_Engine, and the ElementsInSpace method was moved to analytical. Both now work off polylines and regions respectively to allow for wider usage outside of the Environment_Engine.

Test files

Test Script

[FraserGreenroyd]

Minor comments. Somehow I think this will escape needing versioning though which would be cool if so - but let's maybe run the check to be sure.

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[FraserGreenroyd]

Let's fix compliance before checking versioning though 😉

Otherwise from code review this all looks good and in line with what we discussed @enarhi so should be quick enough to settle out.

[pawelbaran]

I had a read through the code and raised a few questions as in the comments - hopefully they make sense, please shout if you prefer to grab a call instead of typing @enarhi 👍

[enarhi]

@BHoMBot check compliance

[bhombot-ci]

@enarhi to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[pawelbaran]

Please don't hate me @enarhi, getting me to review geometry never ends up without comments 😃

[bhombot-ci]

@enarhi to confirm, the following actions are now queued:

• check versioning

[enarhi]

@BHoMBot check versioning

[bhombot-ci]

@enarhi to confirm, the following actions are now queued:

• check versioning

There are 16 requests in the queue ahead of you.

[enarhi]

@BHoMBot check compliance

[bhombot-ci]

@enarhi to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[pawelbaran]

Nice addition to the engine, glad we ironed out the potential bugs ahead of merging - thanks @enarhi!

[pawelbaran]

@FraserGreenroyd is your change request still valid or can we proceed with merging?

[enarhi]

@BHoMBot check required

[bhombot-ci]

@enarhi to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[Tom-Kingstone]

@FraserGreenroyd asked me to go through the test procedures for the IES and XML toolkits, including the new automated test procedures. None of the changes in this PR break any of the existing functionality and all of these tests pass, so I am happy to approve for this case.

[FraserGreenroyd]

I've reviewed the code and run a couple of test scripts. @Tom-Kingstone has run larger test procedures against dependent toolkits which required the IsContaining method originally to ensure that functionality isn't broken which he's reporting is the case, so happy to approve for merge.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge

There are 1 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge