Geometry_Engine: Singular Value Decomposition implemented and applied to FitLine

[pawelbaran]

Issues addressed by this PR

Closes #3278

Test files

General tests are available here
Edge cases covered here

Changelog

Additional comments

Issue originally raised by @peterjamesnugent, but he is still on leave, so adding @FraserGreenroyd and @albinber - please let it hang and leave it to the originator if not enough head space, no rush on this one 👍

EDIT: running into more and more issues with line fitting, I started gathering edge cases. I spent lots of effort trying to get them all covered using the existing analytical solution, but failed, which led me to rewrite FitLine method entirely by switching to numerical solution and adding an implementation of Singular Value Decomposition, inspired by this and that. Now the method is much more robust, which can be seen in the test files.

A follow-up feature would be #3287.

tolerance input to be removed from FitLine in a separate PR, see #3288.

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[bhombot-ci]

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21690504985

[bhombot-ci]

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21690504985

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[bhombot-ci]

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21690575707

[pawelbaran]

@FraserGreenroyd I requested dispensation against document compliance because it seems to be a bug on the side of the bot.

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 9 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

I have run through the test scripts provided and scanned through the code and despite being overly maths heavy, not a lot seems out of place so happy to merge this to unblock #3283 and other work for this sprint.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21690575707

[bhombot-ci]

@FraserGreenroyd I have now provided a passing check on reference 21690575707 as requested.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

[bhombot-ci]

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21691286837

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21691286837

[bhombot-ci]

@FraserGreenroyd I have now provided a passing check on reference 21691286837 as requested.