-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robot toolkit issue213 align with changes in b ho m #219
Robot toolkit issue213 align with changes in b ho m #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used the structural adapters test scripts to push and pull nodes, bars, panels and FEMeshes, with materials and other relevant properties assigned.
Everything seems to work the same!
I get an error on line 50. Robot_Toolkit/Robot_Adapter/Types/DependencyTypes.cs Lines 42 to 50 in 3176851
|
Thanks @alexradne ! Really good catch! Need a null check protection there. @rwemay think this is the cause of the problem we just discussed over skype! |
New error unfortunately:
public static string IDataBaseStringFormat(IBHoMObject obj)
{
return DataBaseStringFormat(obj as dynamic);
} |
Fix pushed again, not able to test, as have quite massive etabs script open right now. Again, thanks @alexradne , and sorry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now working.
Thanks both, push panel working for me too now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushing nodes with constaints still okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working fine - happy to approve!
Pushing to Robot seems to be working as before, no issues experienced. |
NOTE: Depends on
BHoM/BHoM#481
BHoM/BHoM_Engine#951
Issues addressed by this PR
Closes #213
Closes #175
Aligning with changes made in BHoM and Engine
MeshFace methods removed to align with the updated oM
Test files
Please test through as much of existing projects/scripts as possible to ensure the Robot-link is still functioning as before
Changelog
Additional comments