Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot toolkit issue213 align with changes in b ho m #219

Merged
merged 7 commits into from
May 17, 2019

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#481
BHoM/BHoM_Engine#951

Issues addressed by this PR

Closes #213
Closes #175

Aligning with changes made in BHoM and Engine
MeshFace methods removed to align with the updated oM

Test files

Please test through as much of existing projects/scripts as possible to ensure the Robot-link is still functioning as before

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added severity:critical No workaround exists. Essential to continue size:M Measured in hours status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge type:external-api-changes Imposed changes, including from dependency across other BHoM repos labels May 10, 2019
@IsakNaslundBh IsakNaslundBh self-assigned this May 10, 2019
alexradne
alexradne previously approved these changes May 13, 2019
Copy link
Member

@alexradne alexradne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the structural adapters test scripts to push and pull nodes, bars, panels and FEMeshes, with materials and other relevant properties assigned.
Everything seems to work the same!

@alexradne
Copy link
Member

I get an error on line 50. type.BaseType is null for the type MaterialFragment when pushing bars with the new serialised materials.

protected override List<Type> DependencyTypes<T>()
{
Type type = typeof(T);
if (m_DependencyTypes.ContainsKey(type))
return m_DependencyTypes[type];
else if (m_DependencyTypes.ContainsKey(type.BaseType))
return m_DependencyTypes[type.BaseType];

@IsakNaslundBh
Copy link
Contributor Author

Thanks @alexradne ! Really good catch! Need a null check protection there.

@rwemay think this is the cause of the problem we just discussed over skype!

@alexradne
Copy link
Member

New error unfortunately:

1. Solution exception:The best overloaded method match for 'BH.Engine.Robot.Convert.DataBaseStringFormat(BH.oM.Structure.SectionProperties.ISectionProperty)' has some invalid arguments

public static string IDataBaseStringFormat(IBHoMObject obj)
        {
            return DataBaseStringFormat(obj as dynamic);
        }

@IsakNaslundBh
Copy link
Contributor Author

Fix pushed again, not able to test, as have quite massive etabs script open right now.

Again, thanks @alexradne , and sorry!

alexradne
alexradne previously approved these changes May 16, 2019
Copy link
Member

@alexradne alexradne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now working.

@rwemay
Copy link
Member

rwemay commented May 16, 2019

Thanks both, push panel working for me too now.

Copy link
Member

@alexradne alexradne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing nodes with constaints still okay

@IsakNaslundBh IsakNaslundBh removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label May 17, 2019
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine - happy to approve!

@jdarcyBHE
Copy link

Pushing to Robot seems to be working as before, no issues experienced.

@IsakNaslundBh IsakNaslundBh merged commit e159690 into master May 17, 2019
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-Issue213-AlignWithChangesInBHoM branch May 17, 2019 15:47
@alelom alelom restored the Robot_Toolkit-Issue213-AlignWithChangesInBHoM branch May 24, 2019 09:34
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-Issue213-AlignWithChangesInBHoM branch October 7, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical No workaround exists. Essential to continue size:M Measured in hours type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
5 participants