Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merged] fixing build warnings/errors (missing documentation) #14

Closed
wants to merge 9 commits into from

Conversation

retaj
Copy link
Collaborator

@retaj retaj commented Mar 6, 2017

No description provided.

@mschilli87 mschilli87 changed the title ciri demo file added [WIP] fixing build warnings/errors (missing documentatiion) Mar 6, 2017
@mschilli87 mschilli87 changed the title [WIP] fixing build warnings/errors (missing documentatiion) [WIP] fixing build warnings/errors (missing documentation) Mar 6, 2017
@mschilli87
Copy link
Collaborator

@retaj: Once you got the build to work for this PR (by pushing fixes to the docufix branch), please don't merge it here.
Instead, I suggest to close this PR and merge docufix directly into dev2 (as it's independent of the Travis-CI stuff I'm working on in this branch). If you prefer to that that through another PR or simply by a local git checkout dev2 && git merge docufix && git branch -d docufix && git push origin dev2 doesn't matter.


Once this is done, I can rebase the travis branch on dev2 (incl. your docufix changes) and keep working on that before we finally merge my changes back to dev2 when I'm done testing.

@mschilli87
Copy link
Collaborator

mschilli87 commented Mar 6, 2017

There warnings still seem to be there....

@retaj: Does R CMD check work for you locally now?

@retaj
Copy link
Collaborator Author

retaj commented Mar 6, 2017

Looks like it crashed due to some externality (a bioconductor package didn't download), I just reran the Travis build...will not merge to travis branch, just want to see it passing :)

@mschilli87
Copy link
Collaborator

Let's hope this is temporal and a single successful run caches all packages for the future then.

@retaj
Copy link
Collaborator Author

retaj commented Mar 6, 2017

ran devtools::check(), it says:
R CMD check results
0 errors | 0 warnings | 3 notes

notes are mostly bs...complaining about .travis.yaml file :) and variables/functions with no visible global definition (fundamentalist way to say "you guys are using data.table and ggplot2") 🥇

let's see what Travis has to say :)

@mschilli87
Copy link
Collaborator

still 'Undocumented code objects'...

@retaj
Copy link
Collaborator Author

retaj commented Mar 6, 2017

No idea why R:oldrel is still crashing, it should be running 3.2.5 according to Travis doc. SummarizedExperiment depends on R >= 3.2. Whatevs, I restarted the R:oldrel build just in case it was some trivial issue - if it crashes again, feel free to drop the oldrel from .travis.yaml and set R >= 3.3 as a dependency for ciRcus :machiavelli:

@mschilli87
Copy link
Collaborator

Whatever the reason, SummarizedExperiment seems to by unavailable in R 3.2.5.


Can you adjust the dependency R >= 3.3 in the docufix branch & merge it into dev2?

I'll keep care of dropping oldrel from Travis in the travis branch.


I'll close this now as all the information is here.

@mschilli87 mschilli87 closed this Mar 7, 2017
@mschilli87 mschilli87 changed the title [WIP] fixing build warnings/errors (missing documentation) [merged] fixing build warnings/errors (missing documentation) Mar 7, 2017
mschilli87 added a commit that referenced this pull request Mar 7, 2017
@mschilli87
Copy link
Collaborator

@retaj: Regarding the notes complaining about .travis.yml:

If I understood correctly you can make R ignore it by adding the following to .Rbuildignore:

## Ignore travis config file
^\.travis\.yml$

@retaj retaj deleted the docufix branch March 9, 2017 15:03
@mschilli87 mschilli87 removed their assignment Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants