ResizeObserver

[mattaebersold]

@weotch check this out. I found that ditching window.resize and using resize observer helps with the following issue:

• carousel mounts
• something other than window resizing causes it's dimensions to change
• it would not re-calc, so slides would dock appropriately

With this resizeObserver, it listens for dimension changes on the el, rather than window, so it works the same as before, but additionally will re-calc when it changes separately from the window size

https://caniuse.com/resizeobserver

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[cypress]

Passing run #65 ↗︎

0

18

0

0

0

Details:

Update src/concerns/dimensions.coffee
Project: vue-ssr-carousel	Commit: 1b12837da8
Status: Passed	Duration: 04:33 💡
Started: Apr 19, 2023 11:36 PM	Ended: Apr 19, 2023 11:40 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[weotch]

Yeah, this seems smart 👍, just some little tweaks that you can batch apply within GitHub. Then I'll merge and tag it.

[netlify]

✅ Deploy Preview for vue-ssr-carousel ready!

Name	Link
🔨 Latest commit	086bcbc
🔍 Latest deploy log	https://app.netlify.com/sites/vue-ssr-carousel/deploys/64407a947095720008b8a733
😎 Deploy Preview	https://deploy-preview-120--vue-ssr-carousel.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[mattaebersold]

@weotch I've committed those suggestions