detect if we are rendering a tablist #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
✅ Deploy Preview for vue-ssr-carousel ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
weotch
approved these changes
Jun 7, 2023
|
LGTM! Released as 2.3.0 |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the carousel to render a list of button tabs in HFO, and that siteimprove app they started using flagged that elements with a
role="tab"should be immediate children of an element withrole="tablist", so my implementation of passing to thessr-carousel(role="tablist")needs to change, this PR is to solve this issue. Following the same approach we had for deciding whether to render the track as an ul, I'm now doing it to add a role of "tablist" to the track.