Skip to content

Conversation

martinhoT
Copy link

@martinhoT martinhoT commented Aug 19, 2025

Summary

Default checkboxes are now wrapped by a padded label, as indicated in the screenshot below (purple is clickable).

image

Test Plan

Try to click slightly outside the checkbox at the left of a file entry in the file manager. Multi-selection should still work (i.e. previous file selection is not forgotten). Check the size of the label with Dev tools, and verify that the size is appropriate.

Verify the above in the list and grid views.

@martinhoT martinhoT requested review from Rui-Jesus and bastiao August 19, 2025 11:31
@martinhoT martinhoT self-assigned this Aug 19, 2025
@martinhoT martinhoT added the C-enhancement New feature or request label Aug 19, 2025
@martinhoT martinhoT force-pushed the imp/checkbox-click-area branch from 2d75745 to 8155c03 Compare August 19, 2025 11:33
@bastiao
Copy link
Member

bastiao commented Aug 19, 2025

@joselfrias do you know how are we doing release cycle of this component?

@joselfrias
Copy link
Collaborator

Yes.

The way i've been doing is (sorry, I don't have the commands at hand now :/ ) :

  1. Increase the version in this frontend\package.json and run the npm commands to build the new version of the package. At first I tend to create a version like 4.1.1.beta.1 and only when it is approved in other components (we must issue as well a PR that updates the package version in that), I push to GH packages the 4.1.1 version (and issue a new PR in other components to update).
  2. Publish to GH packages (check the token for github, it needs to contain packages permissions).

@martinhoT martinhoT force-pushed the imp/checkbox-click-area branch from 8155c03 to 73b41dc Compare August 20, 2025 10:06
@Rui-Jesus
Copy link

In this PR or the other (I intend to approve both at the same time) can we bump the version at version.txt? Maybe 1.3.1

Copy link

@Rui-Jesus Rui-Jesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rui-Jesus Rui-Jesus merged commit de8c220 into main Aug 25, 2025
@Rui-Jesus Rui-Jesus deleted the imp/checkbox-click-area branch August 25, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants