Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of BOINC_RCSID_ constants #2953

Closed
asgarciap opened this issue Jan 7, 2019 · 3 comments · Fixed by #2963
Closed

Purpose of BOINC_RCSID_ constants #2953

asgarciap opened this issue Jan 7, 2019 · 3 comments · Fixed by #2963

Comments

@asgarciap
Copy link

I have seen several files with those constans

const char *BOINC_RCSID_d9f764fd14="$Id$";

What are they purpose, i greped all of them and see they are not used anywhere in the rest of the code.

@AenBleidd
Copy link
Member

AenBleidd commented Jan 7, 2019 via email

AenBleidd added a commit to AenBleidd/boinc that referenced this issue Jan 12, 2019
This fixes BOINC#2953

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd AenBleidd added this to the Client Release 7.16 milestone Jan 13, 2019
@davidpanderson
Copy link
Contributor

As described in checkin_notes_2004:

Bruce 24 Nov 2004 UTC
- Added const char RCSID string to all *.c files,
so that 'ident' and 'strings' can identify file version numbers.

I don't know if this mechanism still works, but it's not a good idea to remove stuff without knowing why it's there.

@AenBleidd
Copy link
Member

These constants were deleted at least twice. So these are just left-overs that should be (and already) deleted too.
According to the next commit e14e1ca where it is said 'Remove BOINC_RCSID tags from source files, we are doing branching and tagging properly.' made by @romw in 2010 these left-overs are really not necessary anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants