-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boinc platform strings for Android #3740
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3740 +/- ##
==========================================
+ Coverage 15.66% 16.49% +0.82%
==========================================
Files 136 133 -3
Lines 13873 13171 -702
Branches 1770 1630 -140
==========================================
- Hits 2173 2172 -1
+ Misses 11568 10867 -701
Partials 132 132
|
I'm not sure whether these lines are correct or not. |
The official list of platform names is here: |
@truboxl, could you please add similar logic to define |
I think the intention is not to add them to prepare for 64bit only systems. If the devs think it should be included then ok I guess I will add them, Once these added I think can remove |
You still need them in build scripts when cross-compiling for different platforms but if you build it for your native platform - then yes, no need to specify this parameter in build script |
Ah yes you are right This is inline with https://developer.android.com/ndk/guides/standalone_toolchain#projects_using_autoconf and https://github.com/curl/curl/blob/master/docs/INSTALL.md#android |
Some compiled clients may appear as "$ARCH-unknown-linux-android" instead of "$ARCH-android-linux-gnu" to project servers This is because of Android NDK specifies "$ARCH-linux-android" triplets and users forget to specify "--with-boinc-platform" Fix this in "boinc_platform.m4" so that Android boinc platform strings changes are not needed across all projects boinc_alt_platform is excluded to prepare for 64bit only Android devices Users can add back requesting 32bit tasks with "--with-boinc-alt-platform" during compile or "<alt_platform>" during runtime
...triple (see NDK clang -print-target-triple)
Description of the Change
Some compiled clients may appear as
$ARCH-unknown-linux-android
instead of$ARCH-android-linux-gnu
to project serversThis is because of Android NDK specifies
$ARCH-linux-android
triplets andusers forget to specify
--with-boinc-platform
Fix this in
boinc_platform.m4
so that Android boinc platform strings changes are not needed across all projectsboinc_alt_platform is excluded to prepare for 64bit only Android devices
Users can add back requesting 32bit tasks with
--with-boinc-alt-platform
during compile or<alt_platform>
during runtimeAlternate Designs
Feedbacks are welcome.
Release Notes
N/A