Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable iridescence map in MRDL backplate material #12618

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Enable iridescence map in MRDL backplate material #12618

merged 2 commits into from
Jun 1, 2022

Conversation

rgerd
Copy link
Member

@rgerd rgerd commented May 31, 2022

Simple fix, visually pleasing results
ezgif-3-4fa4eb9834

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12618/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12618/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12618/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12618/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12618/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12618/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12618/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12618/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12618/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12618/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12618/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12618/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12618/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12618/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12618/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12618/merge#BCU1XR#0

chinezenwosu-ms
chinezenwosu-ms approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@chinezenwosu-ms chinezenwosu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks Robert

@deltakosh deltakosh merged commit ab7e2b8 into BabylonJS:master Jun 1, 2022
alvov-evo pushed a commit to alvov-evo/Babylon.js that referenced this pull request Jun 16, 2022
@rgerd @alvov-evo
Enable iridescence map in MRDL backplate material (BabylonJS#12618)
3032583 
* Enable iridescence map in MRDL backplate material

* Run prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinezenwosu-ms chinezenwosu-ms chinezenwosu-ms approved these changes

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgerd @deltakosh @chinezenwosu-ms