Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing GUI Editor into Master #9609

Merged
merged 85 commits into from
Jan 6, 2021

Conversation

msDestiny14
Copy link
Contributor

@msDestiny14 msDestiny14 commented Dec 16, 2020

The GUI Editor will be new tool to allow users to create and modify GUI for scenes. It will be a standalone editor similar to NME. This is the foundation PR to officially merge the beginning working codebase into master. This is not a finished editor.

Gui Editor

The GUI editor was created by using the code base of NME, removing the node material specific code, and then adding specific features for the gui editor. While I tried my best to remove most of the node material related code please let me know if there is any extra remaining.

Current features:

  • Launch GUI editor in local dev mode.
  • Drag and drop GUI elements onto a canvas.
  • Select and move individual GUI elements.
  • Modify properties of selected GUI elements.

Important Files: These are the files with the most work done.

  • guiNode.ts – Contains the class responsible for holding all GUI information for each element.
  • workbench.tsx – Contains The class responsible for handling all the GUIs in the center of the screen.
  • workbenchEditor.tsx – Contains the class that holds the workbench and other components for the entire editor.

TODOs:
You will see various places in the code with marked TODOs for future work.
Property tab component is incomplete and has several chunks commented. To be implemented later this week.
Includes property grid components that will be removed once the shared UI work is complete.
Additional comments need to added.

Thank you in advance for your time! :)

@msDestiny14 msDestiny14 marked this pull request as ready for review December 17, 2020 22:04
@msDestiny14 msDestiny14 marked this pull request as draft December 17, 2020 22:06
guiEditor/public/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few comments from me.

guiEditor/src/diagram/guiNode.ts Show resolved Hide resolved
guiEditor/src/diagram/guiNode.ts Outdated Show resolved Hide resolved
guiEditor/src/diagram/guiNode.ts Outdated Show resolved Hide resolved
guiEditor/src/guiEditor.ts Outdated Show resolved Hide resolved
guiEditor/src/guiNodeTools.ts Outdated Show resolved Hide resolved
guiEditor/src/guiNodeTools.ts Outdated Show resolved Hide resolved
guiEditor/src/legacy/legacy.ts Outdated Show resolved Hide resolved
guiEditor/src/sharedComponents/checkBoxLineComponent.tsx Outdated Show resolved Hide resolved
@msDestiny14
Copy link
Contributor Author

@Popov72 love these name suggestions! Going to change them now.

@msDestiny14
Copy link
Contributor Author

@RaananW @Popov72 I leave to you :)

@Popov72
Copy link
Contributor

Popov72 commented Jan 5, 2021

All good for me!

@msDestiny14 msDestiny14 marked this pull request as ready for review January 5, 2021 18:36
@msDestiny14
Copy link
Contributor Author

@RaananW @Popov72 needs someone to hit approve :)

@deltakosh deltakosh merged commit 9fc4ccb into BabylonJS:master Jan 6, 2021
@deltakosh
Copy link
Contributor

congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants