fix: update examples in README and BigIntCoercion class for accurate values #1
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes documentation inconsistencies by updating examples in both the README.md and BigIntCoercion class to reflect accurate computed values for various string-to-BigInt conversions and character operations.
Key changes:
- Updated numeric examples to show correct computed values
- Corrected Unicode character representations in comments
- Fixed string-to-BigInt conversion examples with accurate results
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/bigint-coercion.ts | Updated JSDoc examples to show correct Unicode character and numeric values |
| README.md | Fixed string-to-BigInt conversion examples with accurate computed values and character representations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| * new BigIntCoercion(65n).toChar(); // 'A' | ||
| * new BigIntCoercion(8364n).toChar(); // '€' (Euro sign) | ||
| * new BigIntCoercion(128512n).toChar(); // '😀' (would wrap to 16 bits) | ||
| * new BigIntCoercion(128512n).toChar(); // '' (wraps to 16 bits: 62976) |
There was a problem hiding this comment.
The comment shows an empty string ('') but should show the actual Unicode character for code point 62976. Consider using String.fromCharCode(62976) to show the correct character or explain why it appears empty.
| * new BigIntCoercion(128512n).toChar(); // '' (wraps to 16 bits: 62976) | |
| * new BigIntCoercion(128512n).toChar(); // '' (wraps to 16 bits: 62976) |
Copilot uses AI. Check for mistakes.
No description provided.