[KTLN-712] Initialize a List of Lists in Kotlin #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerasoni
reviewed
Jan 10, 2024
| @Test | ||
| fun `test creating a list of lists using Array() and fill()`() { | ||
| val listOfLists = Array(3) { Array(5) { 0 } } | ||
| assertEquals(3, listOfLists.size) |
There was a problem hiding this comment.
Can we add a space between setup and assertion like you do in the other tests?
acerasoni
reviewed
Jan 10, 2024
| class ListOfListsUnitTest { | ||
|
|
||
| @Test | ||
| fun `test creating a list of lists using listOf()`() { |
There was a problem hiding this comment.
Can we rename the tests to follow the proper naming convention? You can find it here: https://docs.google.com/document/d/1I6eu-eH5D1E0Mkl0Al-4xTgYiK2Ny0PPGtXaN2ToepI/edit
Example:
test creating a list of lists using listOf() -> Creates an immutable list of immutable lists when using listOf()
Please note we should specify what kind of outer and inner lists we are creating (immutable or mutable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests