Skip to content

SCALA-704 Refactored code after received comment. #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged

SCALA-704 Refactored code after received comment. #1305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
962ee45
SCALA-704 Refactored code after received comment.
zeesh49 Apr 26, 2024
9ae02e5
SCALA-704 code formatted.
zeesh49 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions .../scala-core-9/src/main/scala/com/baeldung/scala/isomorphic/IsomorphicStringsChecker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,25 @@ package com.baeldung.scala.isomorphic

object IsomorphicStringsChecker:
def checkIsomorphicBothWays(str1: String, str2: String): Boolean =
if (str1.length == str2.length)
checkIsomorphic(str1, str2) && checkIsomorphic(str2, str1)
else
false
(str1.length == str2.length) && checkIsomorphic(
str1,
str2
) && checkIsomorphic(str2, str1)

def checkIsomorphic2BothWays(str1: String, str2: String): Boolean =
if (str1.length == str2.length)
checkIsomorphic2(str1, str2) && checkIsomorphic2(str2, str1)
else
false
(str1.length == str2.length) && checkIsomorphic2(
str1,
str2
) && checkIsomorphic2(str2, str1)

private def checkIsomorphic(str1: String, str2: String): Boolean =
val z = str1.zip(str2)
// for each distinct pair, count the number of occurrences of tup._1 char
val distinctCounts = z.map(tup => {
z.distinct.count(tupZ => tupZ._1 == tup._1)
})
// if all occurrence occur once only
if (distinctCounts.count(_ > 1) == 0)
true
else
false
distinctCounts.count(_ > 1) == 0

private def checkIsomorphic2(str1: String, str2: String): Boolean =
val z = str1.zip(str2)
val m = z.groupMap(_._1)(_._2)
// println(m)
if (m.forall(_._2.distinct.length == 1))
true
else
false
m.forall(_._2.distinct.length == 1)