This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: suppport tokio backend #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOBLES5E
changed the title
feat: suppport optional tokio backend
feat: suppport tokio backend
Sep 7, 2021
NOBLES5E
suggested changes
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the PR description (which will be in the commit message when merged):
- support tokio backend, in addition to XXXX @shjwudp fill this
- fix the multi-stream non-correspondence problem caused by random accept during the initialization process ( cannot understand, please describe the problem more explicitly, it's ok if the description is more than a paragraph but it should be easy to understand ( In the future, such "fix" should be in separate PR
- Improved unpacking method (same as 2
Since we noticed that AllReduce and All2All (with large/small messages) have different performance characteristics, we now need to update benchmark results to include these different cases instead of just AllReduce
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains two features and one bug fix.
Features:
utils::chunk_size
. This method can divide the communication packet into multiple small packets of equal size as required, and the packet body is not less than the minimum limit.Bug fix:
accept
function is take a connection from the pool of tcp links, Instead of one-to-one correspondence with connection. Any way, I fixed this bug.