This repository was archived by the owner on Nov 29, 2023. It is now read-only.
Paul schemas sippeers move tns & termination #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmeyers99
reviewed
Sep 6, 2022
site/specs-temp/numbers.json
Outdated
| } | ||
| } | ||
| }, | ||
| "/sippeers/products/termination/accounts/{accountId}/sites/{siteId}/sippeers/{sipPeerId}/products/termination": { |
There was a problem hiding this comment.
is this the right path? Shouldn't it be /accounts/{accountId}/sites/{siteId}/sippeers/{sipPeerId}/products/termination
There was a problem hiding this comment.
Yeah, thanks @mrmeyers99, I missed the url-rewrite logic here, addressing
brianluisgomez
previously approved these changes
Sep 6, 2022
|
@mrmeyers99 comment is addressed, paths have been fixed. @brianluisgomez would ask for re-approve, thanks! |
mrmeyers99
approved these changes
Sep 6, 2022
brianluisgomez
approved these changes
Sep 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All spec changes should be done in the api-specs repository.
Please follow the Guide for contributing to our developer documentation.