Csrs, Disconnects #702

pisaychuk · 2022-09-07T12:30:52Z

⚠️Please do not make any changes to spec files in this repository!⚠️

All spec changes should be done in the api-specs repository.

Please follow the Guide for contributing to our developer documentation.

rjamesq · 2022-09-09T08:47:58Z

site/docs/numbers/disconnectNumbers.mdx

@@ -32,19 +32,11 @@ export const Highlight = ({children, color}) => (
 Disconnecting a phone number leaves it in all applicable inventories, but makes it available for activation with a new subscriber.


Suggested change

Disconnecting a phone number leaves it in all applicable inventories, but makes it available for activation with a new subscriber.

To remove a number from your account, disconnect it using the /disconnects endpoint.

@ajrice6713 can you confirm this is correct please :)

@rjamesq That is correct 😄

@pisaychuk can you update this first sentence please :) it looks like it didn't make it in the updates

oops, ok, sorry, didn't get it - for some reason I thought the question was about the original sentence :|

rjamesq · 2022-09-09T08:53:34Z

site/docs/numbers/disconnectNumbers.mdx

-A GET Request to an existing disconnect will return it's status as well as any information originally used to create the disconnect.
+## Checking Disconnect Order Status {#get-disconnect-info}
+
+Disconnects are asynchronous which means the orders are processed and the order status is updated asynchronously. As times can vary and are not guaranteed Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`. Please follow the [How to setup Notification Webhook](/docs/numbers/webhooks/orderWebhook) guide.


Suggested change

Disconnects are asynchronous which means the orders are processed and the order status is updated asynchronously. As times can vary and are not guaranteed Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`. Please follow the [How to setup Notification Webhook](/docs/numbers/webhooks/orderWebhook) guide.

Disconnects are asynchronous which means the orders are processed and the order status is updated at a later time. As times can vary, Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`. Please follow the [How to setup Notification Webhook](/docs/numbers/webhooks/orderWebhook) guide.

rjamesq · 2022-09-09T08:59:10Z

site/docs/numbers/disconnectNumbers.mdx

+This is a webhook that bandwidth sends to _your_ server upon order completion/failure - there is no need to poll the resource if using this recommended method.
+:::
+
+```xml


The POST request is a little confusing and is inside the response section. We link the guide for subscriptions on other guides, so we should remove the subscriptions example for consistency

rjamesq · 2022-09-09T09:03:24Z

site/docs/numbers/porting/csrLookupTool.mdx

@@ -1,7 +1,7 @@
 ---
 id: csrLookupTool
 title: CSR Lookup Tool
-slug: /numbers/guides/csrLookupTool
+slug: /numbers/guides/porting/csrLookupTool
 description: How to lookup CSR records using the Bandwidth API
 keywords:
  - bandwidth


"This guide will walk you through how to programmatically lookup Customer Service Records (CSRs) for Phone Numbers before porting into your Bandwidth account."

rjamesq · 2022-09-09T09:03:55Z

site/docs/numbers/porting/csrLookupTool.mdx

@@ -32,47 +32,18 @@ This walks through how to programmatically lookup Customer Service Records (CSRs

 ## Polling vs. Webhooks

-CSR Orders in the Bandwidth Dashboard are asynchronous when creating an "order". The orders are then processed and the order status is updated asynchronously.  Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`.
+CSR Orders in the Bandwidth Dashboard are asynchronous when creating an "order". The orders are then processed and the order status is updated asynchronously. Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`.


Suggested change

CSR Orders in the Bandwidth Dashboard are asynchronous when creating an "order". The orders are then processed and the order status is updated asynchronously. Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`.

CSR Orders in the Bandwidth Dashboard are asynchronous when creating an "order". The orders are then processed and the order status is updated. Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`.

rjamesq · 2022-09-09T09:04:34Z

site/docs/numbers/porting/csrLookupTool.mdx

@@ -32,47 +32,18 @@ This walks through how to programmatically lookup Customer Service Records (CSRs

 ## Polling vs. Webhooks

-CSR Orders in the Bandwidth Dashboard are asynchronous when creating an "order". The orders are then processed and the order status is updated asynchronously.  Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`.
+CSR Orders in the Bandwidth Dashboard are asynchronous when creating an "order". The orders are then processed and the order status is updated asynchronously. Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`.

 Order processing times can vary and are not guaranteed, so bandwidth does __not__ recommend setting a timeout on waiting for an order to show either `COMPLETE` or `FAILED` status, but instead relying on a webhook from a CSR Orders subscription.


Suggested change

Order processing times can vary and are not guaranteed, so bandwidth does __not__ recommend setting a timeout on waiting for an order to show either `COMPLETE` or `FAILED` status, but instead relying on a webhook from a CSR Orders subscription.

Order processing times can vary, so bandwidth does __not__ recommend setting a timeout on waiting for an order to show either `COMPLETE` or `FAILED` status, but instead relying on a webhook from a CSR Orders subscription.

site/docs/numbers/disconnectNumbers.mdx

site/docs/numbers/porting/csrLookupTool.mdx

# Conflicts: # site/specs-temp/numbers.json

rjamesq · 2022-09-16T12:48:21Z

site/docs/numbers/disconnectNumbers.mdx

@@ -32,19 +32,11 @@ export const Highlight = ({children, color}) => (
 Disconnecting a phone number leaves it in all applicable inventories, but makes it available for activation with a new subscriber.


@pisaychuk can you update this first sentence please :) it looks like it didn't make it in the updates

rjamesq · 2022-09-16T12:51:52Z

site/docs/numbers/disconnectNumbers.mdx

@@ -132,3 +119,6 @@ Content-Type: application/xml; charset=utf-8
 </DisconnectTelephoneNumberOrderResponse>

 ```
+


can you add a section at the bottom and link them to "How to search and order a number"

Csrs, Disconnect

f5c3599

pisaychuk requested a review from a team September 7, 2022 12:30

ajrice6713 requested a review from rjamesq September 8, 2022 13:27

gocab-bw self-requested a review September 8, 2022 19:28

rjamesq reviewed Sep 9, 2022

View reviewed changes

gocab-bw suggested changes Sep 9, 2022

View reviewed changes

pisaychuk added 4 commits September 12, 2022 12:44

Address PR comments

c6f5fa3

Address PR comments

217f228

Merge remote-tracking branch 'upstream/main' into LNP_guides

a6ec015

# Conflicts: # site/specs-temp/numbers.json

Address PR comments

4f0a9c4

gocab-bw previously approved these changes Sep 12, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/main' into LNP_guides

4febeef

rjamesq reviewed Sep 16, 2022

View reviewed changes

Address review comments

7f9aa1f

pisaychuk dismissed gocab-bw’s stale review via 7f9aa1f September 16, 2022 13:11

Merge remote-tracking branch 'upstream/main' into LNP_guides

6409bfe

gocab-bw approved these changes Sep 16, 2022

View reviewed changes

rjamesq approved these changes Sep 16, 2022

View reviewed changes

ajrice6713 approved these changes Sep 16, 2022

View reviewed changes

ajrice6713 merged commit 558dc2d into Bandwidth:main Sep 16, 2022

		@@ -32,19 +32,11 @@ export const Highlight = ({children, color}) => (
		Disconnecting a phone number leaves it in all applicable inventories, but makes it available for activation with a new subscriber.

	Disconnecting a phone number leaves it in all applicable inventories, but makes it available for activation with a new subscriber.
	To remove a number from your account, disconnect it using the /disconnects endpoint.

	Disconnects are asynchronous which means the orders are processed and the order status is updated asynchronously. As times can vary and are not guaranteed Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`. Please follow the [How to setup Notification Webhook](/docs/numbers/webhooks/orderWebhook) guide.
	Disconnects are asynchronous which means the orders are processed and the order status is updated at a later time. As times can vary, Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`. Please follow the [How to setup Notification Webhook](/docs/numbers/webhooks/orderWebhook) guide.

	CSR Orders in the Bandwidth Dashboard are asynchronous when creating an "order". The orders are then processed and the order status is updated asynchronously. Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`.
	CSR Orders in the Bandwidth Dashboard are asynchronous when creating an "order". The orders are then processed and the order status is updated. Bandwidth recommends configuring your account with a subscription instead of polling the order resource for `<OrderStatus>`.

	Order processing times can vary and are not guaranteed, so bandwidth does __not__ recommend setting a timeout on waiting for an order to show either `COMPLETE` or `FAILED` status, but instead relying on a webhook from a CSR Orders subscription.
	Order processing times can vary, so bandwidth does __not__ recommend setting a timeout on waiting for an order to show either `COMPLETE` or `FAILED` status, but instead relying on a webhook from a CSR Orders subscription.

		@@ -132,3 +119,6 @@ Content-Type: application/xml; charset=utf-8
		</DisconnectTelephoneNumberOrderResponse>

		```

Csrs, Disconnects #702

Csrs, Disconnects #702

Uh oh!

Conversation

pisaychuk commented Sep 7, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!