This repository was archived by the owner on Nov 29, 2023. It is now read-only.
DX-2790 Update Landing Page #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* e911, edgemanagement, sipauthentication settings api spec (#701) Co-authored-by: ichesnov <ichesnov@cybervisiontech.com> * DX-2816 Updates to Voice About Page * workflow * branch * remove workflow change * Update hangup.mdx (#707) Fix a broken hyperlink * add stream panel * workflow * remove branch Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com> Co-authored-by: ichesnov <ichesnov@cybervisiontech.com> Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com>
ajrice6713
reviewed
Nov 10, 2022
matthewkmartin
suggested changes
Nov 10, 2022
site/src/components/Carousel.js
Outdated
| width: `${itemContentWidth}px`, | ||
| height: `${itemContentWidth * .51}px`, | ||
| backgroundImage: `url(${imageUrl})`, | ||
| backgroundSize: `cover`, |
There was a problem hiding this comment.
I am not super well versed on CSS here- it seems that the returned tags below use both a CSS class and a style. I would assume this is so we can have dynamic aspects of our style determined in JS to apply to our components. If this is the case, should these static values be moved out to the static CSS classes?
There was a problem hiding this comment.
These static values can be moved to a static css class, but for the image div, I didn't define a class so this style object is the only thing affecting the div. I can pull these out into a static class though.
There was a problem hiding this comment.
that's a lie I do have a class for these 🤡
ajrice6713
approved these changes
Nov 10, 2022
matthewkmartin
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.