Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Conversation

DX-Bandwidth
Copy link
Contributor

@DX-Bandwidth DX-Bandwidth commented Sep 21, 2022

BYOIDP related documentation.
To view the site how it would look with the Identity stuff, un-comment all the places that have TODO ONEID-1304.

@github-actions
Copy link
Contributor

…k with the new structure. I probably missed some things
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@derelbenkoenig derelbenkoenig marked this pull request as ready for review September 28, 2022 20:06
@derelbenkoenig derelbenkoenig requested a review from a team September 28, 2022 20:06
@derelbenkoenig derelbenkoenig marked this pull request as draft September 28, 2022 20:07
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@cypress
Copy link

cypress bot commented Sep 29, 2022



Test summary

234 0 0 0Flakiness 1


Run details

Project api-docs
Status Passed
Commit 5df036c
Started Nov 9, 2022 3:14 PM
Ended Nov 9, 2022 3:24 PM
Duration 09:02 💡
OS Linux Ubuntu - 20.04
Browser Chrome 107

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/tests/docs_sidebar.cy.js Flakiness
1 Testing the Docs Sidebar Tabs > Should verify that the Multi-Factor Authentication tab and subtabs opens and closes properly

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022


### Information you need from us

Your identity provider will need information about our service provider to know whom to trust and whither to send information.
Copy link

@rstevens-bw rstevens-bw Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whither -> whether ? i suppose either works now that i think about that more

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant "whither" in the sense of "to where"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People who don't know that word should simply go read some Tolkien

---
## Configuring Your Identity Provider

Configuring your identity provider for Bandwidth will require you have a few pieces of information ready. You will need

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably drop the tailing ' You will need'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah I forgot to do that


### Can I delete an IdP while it is still active?

You cannot delete an IdP if it is currently active. You must first deactivate it before deleting the IdP. If you attempt to delete an IdP that is still active you will recieve a `409 Conflict` HTTP status.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick, double space between active and you

rstevens-bw
rstevens-bw previously approved these changes Oct 6, 2022
@github-actions
Copy link
Contributor

tmonck
tmonck previously approved these changes Oct 12, 2022
@DX-Bandwidth
Copy link
Contributor Author

Corresponding Pull Request on api-specs was merged.

derelbenkoenig
derelbenkoenig previously approved these changes Nov 8, 2022
Copy link

@derelbenkoenig derelbenkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a lot of this but I'll approve it anyway, we may still want more approvals from others but I'm indicating that in my opinion this is ready

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

rstevens-bw
rstevens-bw previously approved these changes Nov 9, 2022
ajrice6713
ajrice6713 previously approved these changes Nov 9, 2022
@ajrice6713 ajrice6713 dismissed stale reviews from rstevens-bw and themself via 5df036c November 9, 2022 14:54
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

@ajrice6713 ajrice6713 merged commit b68fc77 into main Nov 9, 2022
@ajrice6713 ajrice6713 deleted the ONEID-1323 branch November 9, 2022 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants