Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Conversation

xxlaykxx
Copy link
Contributor

POST GET PUT /accounts/{accountId}/products/uctrunking/features/hosted/settings

Снимок экрана 2022-09-24 в 12 36 47

Снимок экрана 2022-09-24 в 12 37 04

Снимок экрана 2022-09-24 в 12 36 55

@xxlaykxx xxlaykxx requested a review from a team September 24, 2022 09:42
Copy link
Contributor

@mrmeyers99 mrmeyers99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better tag you could use? We're trying to get rid of /accounts

@xxlaykxx
Copy link
Contributor Author

xxlaykxx commented Oct 2, 2022

@mrmeyers99 we have several GET endpoints for different product settings - I could add one tag for all of them like "Product Settings", What do you think?

@mrmeyers99
Copy link
Contributor

@mrmeyers99 we have several GET endpoints for different product settings - I could add one tag for all of them like "Product Settings", What do you think?

That makes sense to me. I'm happy for that to be a separate PR though.

@xxlaykxx
Copy link
Contributor Author

xxlaykxx commented Oct 3, 2022

Ok, then let's merge this one and I will creat another pr with new tag

@mrmeyers99 mrmeyers99 merged commit 371cf46 into Bandwidth:main Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants