Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

DX-3333 Add Skeleton for new Porting Guides #956

Merged
merged 21 commits into from
Mar 9, 2023
Merged

DX-3333 Add Skeleton for new Porting Guides #956

merged 21 commits into from
Mar 9, 2023

Conversation

ajrice6713
Copy link
Contributor

⚠️Please do not make any changes to spec files in this repository!⚠️

All spec changes should be done in the api-specs repository.

Please follow the Guide for contributing to our developer documentation.

@cypress
Copy link

cypress bot commented Feb 20, 2023

1 flaky tests on run #1402 ↗︎

0 243 0 0 Flakiness 1

Details:

DX-3333 Add Skeleton for new Porting Guides
Project: api-docs Commit: cff8ed789e
Status: Passed Duration: 09:38 💡
Started: Mar 9, 2023 8:08 PM Ended: Mar 9, 2023 8:18 PM
Flakiness  cypress/e2e/tests/migration_guides_sidebar.cy.js • 1 flaky test

View Output Video

Test Artifacts
Testing the Migration Guides Sidebar Tabs > Should verify that the Python tab and subtabs opens and closes properly Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

ajrice6713 and others added 2 commits February 28, 2023 14:03
* Add Code Snippets to Spec Files

* Add Code Snippets to Spec Files

* Add Code Snippets to Spec Files

* MV-8384 add campaign vetting status and denial reason to campaign response examples

* MV-8384 rename one field

* MV-8384 vary responses

* Add Code Snippets to Spec Files

* Add Code Snippets to Spec Files

* Add Code Snippets to Spec Files

* Add Code Snippets to Spec Files

* add porting docs

* Format + cleanup to fit DX-3333 structure

---------

Co-authored-by: DX-Bandwidth <dx@bandwidth.com>
Co-authored-by: bandwidthjon <jjackson@bandwidth.com>
Co-authored-by: adark <adark@bandwidth.com>
Co-authored-by: DX-Bandwidth <42817071+DX-Bandwidth@users.noreply.github.com>
Co-authored-by: Nirmit Patel <npatel@bandwidth.com>
Co-authored-by: jgilmore-bw <jgilmore@bandwidth.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

jgilmore-bw and others added 2 commits March 2, 2023 18:15
…DX-3333

Additional corrections to document cross-ref links.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Copy link
Contributor

@jdunster-bw jdunster-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look pretty good overall! I just left a few comments - most of them are pretty nit-picky, so you can feel free to ignore the grammar/formatting changes.

@ckoegel
Copy link
Contributor

ckoegel commented Mar 8, 2023

Hey guys, I just made a bunch of formatting updates to the markdown, let me know if anything still looks wrong or needs fixing

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Co-authored-by: Josh Dunster <76067287+jdunster-bw@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

@jgilmore-bw jgilmore-bw marked this pull request as ready for review March 8, 2023 18:12
@jgilmore-bw jgilmore-bw requested a review from a team March 8, 2023 18:12
jgilmore-bw and others added 2 commits March 8, 2023 15:58
Co-authored-by: Josh Dunster <76067287+jdunster-bw@users.noreply.github.com>
Co-authored-by: Josh Dunster <76067287+jdunster-bw@users.noreply.github.com>
jdunster-bw
jdunster-bw previously approved these changes Mar 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

@jgilmore-bw jgilmore-bw merged commit c662c06 into main Mar 9, 2023
@jgilmore-bw jgilmore-bw deleted the DX-3333 branch March 9, 2023 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants