This repository was archived by the owner on Nov 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
DX-3333 Add Skeleton for new Porting Guides #956
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky tests on run #1402 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Testing the Migration Guides Sidebar Tabs > Should verify that the Python tab and subtabs opens and closes properly |
Output
Screenshots
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
* Add Code Snippets to Spec Files * Add Code Snippets to Spec Files * Add Code Snippets to Spec Files * MV-8384 add campaign vetting status and denial reason to campaign response examples * MV-8384 rename one field * MV-8384 vary responses * Add Code Snippets to Spec Files * Add Code Snippets to Spec Files * Add Code Snippets to Spec Files * Add Code Snippets to Spec Files * add porting docs * Format + cleanup to fit DX-3333 structure --------- Co-authored-by: DX-Bandwidth <dx@bandwidth.com> Co-authored-by: bandwidthjon <jjackson@bandwidth.com> Co-authored-by: adark <adark@bandwidth.com> Co-authored-by: DX-Bandwidth <42817071+DX-Bandwidth@users.noreply.github.com> Co-authored-by: Nirmit Patel <npatel@bandwidth.com> Co-authored-by: jgilmore-bw <jgilmore@bandwidth.com>
…DX-3333 Additional corrections to document cross-ref links.
jdunster-bw
reviewed
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look pretty good overall! I just left a few comments - most of them are pretty nit-picky, so you can feel free to ignore the grammar/formatting changes.
site/docs/numbers/porting/port-ins/stand-alone-port-ins/tollFreePortabilityValidations.mdx
Outdated
Show resolved
Hide resolved
site/docs/numbers/porting/port-ins/stand-alone-port-ins/tollFreePortabilityValidations.mdx
Outdated
Show resolved
Hide resolved
Hey guys, I just made a bunch of formatting updates to the markdown, let me know if anything still looks wrong or needs fixing |
Co-authored-by: Josh Dunster <76067287+jdunster-bw@users.noreply.github.com>
Co-authored-by: Josh Dunster <76067287+jdunster-bw@users.noreply.github.com>
Co-authored-by: Josh Dunster <76067287+jdunster-bw@users.noreply.github.com>
jdunster-bw
previously approved these changes
Mar 8, 2023
ckoegel
approved these changes
Mar 8, 2023
jdunster-bw
approved these changes
Mar 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All spec changes should be done in the api-specs repository.
Please follow the Guide for contributing to our developer documentation.