SWI-3665 Update SDK Based on Recent Spec Changes #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianluisgomez
previously approved these changes
Oct 3, 2023
ajrice6713
previously approved these changes
Oct 3, 2023
ckoegel
dismissed stale reviews from ajrice6713 and brianluisgomez
need to add tests first
|
Putting this in draft - we cant add tests till GET /calls goes GA on 8/9 |
ckoegel
previously approved these changes
Nov 1, 2023
ajrice6713
requested changes
Nov 1, 2023
| @@ -61,7 +62,7 @@ public class CallsApiTest { | |||
| private static CallbackMethodEnum callbackMethod = CallbackMethodEnum.POST; | |||
| private static String testCallId = "Call-Id"; | |||
| private static String testXmlBody = "<?xml version=\"1.0\" encoding=\"UTF-8\"?><Bxml><SpeakSentence locale=\"en_US\" gender=\"female\" voice=\"susan\">This is a test bxml response</SpeakSentence><Pause duration=\"3\"/></Bxml>"; | |||
| private static int TEST_SLEEP = 3; | |||
| private static int TEST_SLEEP = 6; | |||
There was a problem hiding this comment.
I think we want to set this to 40 to mimic voice api teams alarm, right @ckoegel ?
There was a problem hiding this comment.
this one should also be fine cause we use it in multiple spots, we should just update the sleep for get call state to be 40s
| @@ -62,8 +62,8 @@ public class ConferencesApiTest { | |||
| private static URI answerUrl; | |||
| private static URI conferenceRedirectUrl; | |||
| private static String updateRecordingBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\"?><Bxml><StartRecording/><SpeakSentence locale=\"en_US\" gender=\"female\" voice=\"susan\">This should be a conference recording.</SpeakSentence><StopRecording/></Bxml>"; | |||
| private static int TEST_SLEEP = 3; | |||
| private static int MAX_RETRIES = 40; | |||
| private static int TEST_SLEEP = 6; | |||
There was a problem hiding this comment.
Same here, set the sleep to 40 and dont retry.
There was a problem hiding this comment.
Here I believe this is used for waiting for the recording to finish, so we want to sleep less and retry to poll manteca
ckoegel
reviewed
Nov 1, 2023
Co-authored-by: Cameron Koegel <53310569+ckoegel@users.noreply.github.com>
ajrice6713
approved these changes
Nov 1, 2023
ckoegel
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated by Update SDK Workflow