SWI-3339 Regenerate using OpenAPI Generator v7.0.0 #95
Conversation
.github/workflows/maven.yml
Outdated
There was a problem hiding this comment.
Is there a reason we're downgrading the Java version and setup action version?
There was a problem hiding this comment.
hmm, idk why this got changed. will revert.
api/openapi.yaml
Outdated
There was a problem hiding this comment.
do we need this file any more? I thought we were going to use only bandwidth.yml going forward
There was a problem hiding this comment.
This is autogenerated by the openapi-generator - its listed in the .openapi-generator/FILES file
| @@ -209,10 +209,8 @@ public void testConferenceRecordings() throws Exception { | |||
|
|
|||
| Boolean testRecordingStatus = false; | |||
| for (int i = 0; i < MAX_RETRIES; i++) { | |||
| while (!testRecordingStatus) { | |||
There was a problem hiding this comment.
This is always going to go for the max amount of time now right? And once it hits MAX_RETRIES, the testRecordingStatus might still not be true. Do we need to change some of the logic here?
There was a problem hiding this comment.
yes, it will retry for the max amount of times
with that while statement it was actually infinitely looping so that wasnt good 😅
we need to just remove this and other integration tests going forward, but thats a seperate ticket
No description provided.