Skip to content

SWI-3362 Rename Package to com.bandwidth.sdk #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 29, 2023
Merged

SWI-3362 Rename Package to com.bandwidth.sdk #97

merged 11 commits into from
Aug 29, 2023

Conversation

ajrice6713
Copy link
Contributor

@hamermike is this going to be an issue? The current package is named com.bandwidth - i think com.bandwidth.sdk is more appropriate

@ajrice6713 ajrice6713 marked this pull request as ready for review August 29, 2023 15:39
@ajrice6713 ajrice6713 requested a review from a team August 29, 2023 15:39
ckoegel
ckoegel reviewed Aug 29, 2023
View reviewed changes
.github/workflows/maven.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this got reverted again

.DS_Store Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

ckoegel
ckoegel reviewed Aug 29, 2023
View reviewed changes
src/main/java/com/bandwidth/sdk/model/AnswerCallback.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file

ckoegel
ckoegel reviewed Aug 29, 2023
View reviewed changes
@ajrice6713 ajrice6713 merged commit d08292f into feature/openapi-generator-sdk Aug 29, 2023
@ajrice6713 ajrice6713 deleted the SWI-3362 branch August 29, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckoegel ckoegel ckoegel approved these changes

+2 more reviewers

@hamermike hamermike hamermike left review comments

@juliajanu juliajanu juliajanu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajrice6713 @hamermike @ckoegel @juliajanu