Skip to content

Conversation

braxter
Copy link

@braxter braxter commented Aug 8, 2017

  • Composer updates

    • Require php >= 5.4 since traits and short array syntax are used.
    • Remove duplicate requirements from require-dev
    • Remove 'reference' from composer.json - Versions should be tagged or use the version property (tagging is helpful with packagist as well)
  • phpunit Updates

    • phpunit will be installed in /bin directory with composer
    • Update composer to require phpunit
    • update documents to show new path

Brandon Raxter added 2 commits August 8, 2017 17:39
Require php >= 5.4 since traits and short array syntax are used.
Remove duplicate requirements from require-dev
Remove 'reference' from composer.json - Versions should be tagged
phpunit will be installed in /bin directory with composer
Update composer to require phpunit
update documents to show new path
@dtolb
Copy link

dtolb commented Aug 8, 2017

@braxter Thanks for opening! I'll review tomorrow.

@braxter
Copy link
Author

braxter commented Aug 9, 2017

I thought about things a bit more.

guzzlehttp/guzzle requires: "php": ">=5.5"

It would probably make sense to just bump the composer.json to that same version to reduce confusion.

@dtolb
Copy link

dtolb commented Aug 9, 2017

do you want to make that change real quick ?

aligns php requrements with Guzzle
@braxter
Copy link
Author

braxter commented Aug 9, 2017

composer.json has been updated.

@dtolb dtolb merged commit 1e771ba into Bandwidth:master Aug 10, 2017
@braxter
Copy link
Author

braxter commented Aug 10, 2017

One last thing. You will need create a tag for tag v0.0.11 on master, then things should be usable with composer minimum-stability set to stable.

@dtolb
Copy link

dtolb commented Aug 10, 2017

@braxter since this hadn't had any tags previously I'm going to move this to v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants