Skip to content

Dx 995 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 3, 2020
Merged

Dx 995 #58

merged 10 commits into from
Mar 3, 2020

Conversation

jmulford-bw
Copy link
Contributor

No description provided.

@jmulford-bw
Copy link
Contributor Author

I don't know why the build failed. Only failed for php 5.5 and it wasn't due to any code. No concern from me on that

@jmulford-bw jmulford-bw requested review from dtolb and jchavez443 March 3, 2020 16:52
jchavez443
jchavez443 approved these changes Mar 3, 2020
View reviewed changes
Copy link

@jchavez443 jchavez443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jmulford-bw jmulford-bw merged commit ac7170b into master Mar 3, 2020
@ajrice6713 ajrice6713 deleted the DX-995 branch June 1, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@dtolb dtolb dtolb approved these changes

@jchavez443 jchavez443 jchavez443 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmulford-bw @dtolb @jchavez443