Skip to content

VAPI-2528 Fix Start Stream BXML Bug #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

VAPI-2528 Fix Start Stream BXML Bug #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bandwidth/models/bxml/verbs/start_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
class StartStream(NestableVerb):

def __init__(
self, destination: str, destination_username: str,
destination_password: str, stream_params: List[StreamParam] = [],
self, destination: str, destination_username: str=None,
destination_password: str=None, stream_params: List[StreamParam] = [],
name: str=None, mode: str=None, tracks: str=None,
stream_event_url: str=None,
stream_event_method: str=None,
Expand Down Expand Up @@ -59,8 +59,8 @@ def __init__(
def _attributes(self):
return {
"destination": self.destination,
"destination_username": self.destination_username,
"destination_password": self.destination_password,
"destinationUsername": self.destination_username,
"destinationPassword": self.destination_password,
"name": self.name,
"mode": self.mode,
"tracks": self.tracks,
Expand Down
4 changes: 2 additions & 2 deletions test/unit/models/bxml/test_start_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ def test_instance(self):
assert isinstance(self.start_stream, Verb)

def test_to_bxml(self):
expected = '<StartStream destination="testurl.com" destination_username="dest_user" destination_password="dest_pass" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /></StartStream>'
expected = '<StartStream destination="testurl.com" destinationUsername="dest_user" destinationPassword="dest_pass" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /></StartStream>'
assert expected == self.start_stream.to_bxml()

def test_add_verb(self):
expected = '<StartStream destination="testurl.com" destination_username="dest_user" destination_password="dest_pass" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /><StreamParam name="name2" value="value2" /></StartStream>'
expected = '<StartStream destination="testurl.com" destinationUsername="dest_user" destinationPassword="dest_pass" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /><StreamParam name="name2" value="value2" /></StartStream>'
self.start_stream.add_verb(self.stream_param2)
assert expected == self.start_stream.to_bxml()