Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQRTSS use wrong operand types #39

Closed
Kashio opened this issue Jan 14, 2023 · 2 comments
Closed

SQRTSS use wrong operand types #39

Kashio opened this issue Jan 14, 2023 · 2 comments

Comments

@Kashio
Copy link

Kashio commented Jan 14, 2023

Right now SQRTSS encoded with opcode F3 0F 51 use operand type ss for its operand of addressing W which is defined as:

Scalar element of a 128-bit packed single-precision floating data.

According to the intel docs:

Computes the square root of the low single-precision floating-point value in the second source operand and stores the single-precision floating-point result in the destination operand. The second source operand can be an XMM register or a 32-bit memory location. The first source and destination operands is an XMM register.

Since it's only operate on the lower 32 bits of the register and the memory variant is also referencing 32 bit memory the operand type should be of type d which is defined as:

Doubleword, regardless of operand-size attribute.

Kashio added a commit to Kashio/x86reference that referenced this issue Jan 14, 2023
Kashio added a commit to Kashio/x86reference that referenced this issue Jan 14, 2023
Kashio added a commit to Kashio/x86reference that referenced this issue Jan 14, 2023
@BarebitOpenSource
Copy link
Contributor

This one looks right. Refer to #23.

@BarebitOpenSource
Copy link
Contributor

Feel free to reopen this issue if you still think the operand type is wrong.

@BarebitOpenSource BarebitOpenSource closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants