Updated plugin and made small improvements and changes

[JDDV]

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

• Updated pubspec.yaml to newer versions of SDK and flutter and adding flutter_lints as a dependency;
• Updated analysis_options.yaml for using flutter_lints;
• Updated code according to the set lint rule(s);
• Updated compileSdkVersion and targetSdkVersion in the build.gradle
• Fixed bug were starting the example app would close on running for the first time by adding internet permission in the AndroidManifest

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

• All projects build
• Follows style guide lines (code style guide)
• Relevant documentation was updated
• Rebased onto current develop

[mvanbeusekom]

@JDDV, I think you can fix the analyser error by adding the flutter_lints: ^1.0.4 dependency to the pubspec.yaml file inside the example folder.

[JDDV]

@JDDV, I think you can fix the analyser error by adding the flutter_lints: ^1.0.4 dependency to the pubspec.yaml file inside the example folder.

I did that first as a fix, but I changed it to adding these lines in the option_analysis.yaml:

# workaround for https://github.com/dart-lang/sdk/issues/42910
    - 'example/**'

since that how it initialy was, should I change it back?

[mvanbeusekom]

I did that first as a fix, but I changed it to adding these lines in the option_analysis.yaml:

# workaround for https://github.com/dart-lang/sdk/issues/42910
    - 'example/**'

since that how it initialy was, should I change it back?

Yes I think you should only add the dependency to the example/pubspec.yaml file but do not add a separate analysis_options.yaml file (I noticed you added this file as well in your first attempt to fix the error).

And make sure to remove the - 'example/**' line from the root analysis_options.yaml file.

[JDDV]

I did that first as a fix, but I changed it to adding these lines in the option_analysis.yaml:

# workaround for https://github.com/dart-lang/sdk/issues/42910
    - 'example/**'

since that how it initialy was, should I change it back?

Yes I think you should only add the dependency to the example/pubspec.yaml file but do not add a separate analysis_options.yaml file (I noticed you added this file as well in your first attempt to fix the error).

And make sure to remove the - 'example/**' line from the root analysis_options.yaml file.

Done

[codecov]

Codecov Report

Merging #27 (4be9888) into master (acd40d1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           13        12    -1     
=========================================
- Hits            13        12    -1     

Impacted Files	Coverage Δ
lib/src/google_api_availability.dart	100.00% <ø> (ø)
.../src/models/google_play_services_availability.dart	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd40d1...4be9888. Read the comment docs.

[mvanbeusekom]

LGTM