Skip to content

Conversation

JDDV
Copy link
Contributor

@JDDV JDDV commented Jul 22, 2021

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Fixed a bug where locationAlways returned sometimes PermissionStatus.Denied instead of PermissionStatus.Granted.

⤵️ What is the current behavior?

locationAlways now returns somtimes the wrong PermissionStatus.

🆕 What is the new behavior (if this is a feature change)?

locationAlways now returns the correct PermissionStatus.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

Issue number #620

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #629 (cafadf0) into master (8350aaf) will increase coverage by 10.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           master      #629       +/-   ##
============================================
+ Coverage   89.71%   100.00%   +10.28%     
============================================
  Files           7         1        -6     
  Lines         107        16       -91     
============================================
- Hits           96        16       -80     
+ Misses         11         0       -11     
Impacted Files Coverage Δ
..._platform_interface/lib/src/permission_status.dart
...lib/src/permission_handler_platform_interface.dart
..._interface/lib/src/method_channel/utils/codec.dart
...hod_channel/method_channel_permission_handler.dart
...andler_platform_interface/lib/src/permissions.dart
...ler_platform_interface/lib/src/service_status.dart

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8350aaf...cafadf0. Read the comment docs.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a very small grammar mistake in the changelog description.

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
@mvanbeusekom mvanbeusekom merged commit 8c77c8f into master Jul 22, 2021
@mvanbeusekom mvanbeusekom deleted the issue/fix_601_location_always_permission_bug branch July 22, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants