Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidprompt Theme #1005

Merged
merged 2 commits into from
Jul 16, 2017
Merged

Liquidprompt Theme #1005

merged 2 commits into from
Jul 16, 2017

Conversation

con-f-use
Copy link
Contributor

see: https://github.com/nojhan/liquidprompt

Might be a bit hacky, but people can improve on it.

see: https://github.com/nojhan/liquidprompt

Might be a bit hacky, but people can improve on it.
if cd "$targetdir" &>/dev/null && git rev-parse --is-inside-work-tree &>/dev/null; then
true
else
git clone https://github.com/nojhan/liquidprompt.git "$targetdir" && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a directory $BASH_IT/themes/liquidprompt/liquidprompt, which is then shown as untracked to the Bash-it Git repo.

Can you please add a .gitignore file in themes/liquidprompt, which ignores the nested liquidprompt folder?

┌─16-17:33[foo@foo-macbook:~/.bash_it] 1b9e2:con-f-use-master* ± 
└▪ git status
On branch con-f-use-master
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	themes/liquidprompt/liquidprompt/

@nwinkler
Copy link
Member

One other comment: Liquidprompt uses the AGPL v3 license. Bash-it currently does not have a license...

I'm not a lawyer, I don't know whether cloning the Liquidprompt repo from the Bash-it code does have any consequences. Does it make Bash-it AGPL by default? Or would that only be the case if Bash-it included the actual code of Liquidprompt?

@con-f-use
Copy link
Contributor Author

con-f-use commented Jul 16, 2017

Okay, I added the ignore file.

As to the GPL issue: I was thinking about the license, too. That's why liquidprompt is downloaded only when the user activates the theme. I'm not a lawyer either but it is my understanding, that this way bash-it does not "convey" liquidprompt in the sense of the AGPL. Rather the user modifies bash-it himself to include liquidprompt. And the user is allowed to do that without forcing him to release his modified version under AGPL. See the GPL FAQ:

Does the GPL require that source code of modified versions be posted to the public?

The GPL does not require you to release your modified version, or any part of it. You are free to make modifications and use them privately, without ever releasing them. This applies to organizations (including companies), too; an organization can make a modified version and use it internally without ever releasing it outside the organization.

But if you release the modified version to the public in some way, the GPL requires you to make the modified source code available to the program's users, under the GPL.

To be sure we could add a yes/no question saying "By cloning liquidprompt, you the user, modify bash-it with AGPL-licensed software. You are allowed to use your modified version freely, but should you wish to release it, it must be under the terms of AGPL. This does constitute a release of the original bash-it, which explicitly does not "convey" liquidpromt in the sense of the AGPL. Do you wish to modify bash-it? [y/n]". But I think it would be overkill.

I see it like a download button for a chrome extension. Just by clicking download, the license of chrome doesn't suddenly change. Licenses never automatically change. Worst case GNU or the owners of liquidprompt can force you by court-order make to make the choice between either taking liquidprompt out of bash-it, OR releasing bash-it under AGPL. And then you just take it out. Or in other words just because somebody sells stolen goods, ALL is property isn't suddenly going to change owner.

@nwinkler nwinkler merged commit b9101e5 into Bash-it:master Jul 16, 2017
@nwinkler
Copy link
Member

Thanks - looks good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants