Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate jib during jail import #598

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

JRGTH
Copy link
Collaborator

@JRGTH JRGTH commented Jul 19, 2023

This import enhancement will locate/install the jib script required by VNET jails.

Issue/Bug reference: #597

@joh-ku
Copy link

joh-ku commented Jul 20, 2023

Hi @JRGTH, thanks for the quick PR. For the avoidance of redundant code, wouldn't it be sufficient to check for jib in start.sh only?

@JRGTH
Copy link
Collaborator Author

JRGTH commented Jul 20, 2023

Hi @joh-ku, The jib command should be installed just once upon a VNET jail creation or a VNET jail import(bug fix issued) as you've reported, unless manually installed by user.

Also yes the jib validation can be done in the start.sh command as well but if the user have lots of VNET jails this may lead for several grep command executions which is unnecessary.

@joh-ku
Copy link

joh-ku commented Jul 20, 2023

Understood, thank you for the clarification.

@bmac2 bmac2 merged commit 91f479e into BastilleBSD:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants