-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .devcontainer capabilities #64
base: develop
Are you sure you want to change the base?
Conversation
Also have to uncomment from .gitignore
I was just going to do this for the Acceptance Criteria work. I'll review. |
Why is the |
I cannot run the tests and it appears the dev container does not install |
"davidanson.vscode-markdownlint", | ||
"bierner.markdown-mermaid", | ||
"takumii.markdowntable", | ||
"github.copilot", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommending removing copilot
given it's a subscription service.
It's also not clear to me if |
It would also be nice to update GitHub Actions to use the same environment. With this change in place we'll be developing in one environment, testing in another, and asking users to run in it in a third. We're kind of stuck with two, given the Emme dependency, but it would be good to limit the Linux environments to one. |
What are your thoughts on being more prescriptive about Python (and conda, if we switch to a conda-based container) package versions in the |
What existing problem does the pull request solve and why should we include it?
As a developer, I'd like to work in a consistent development environment.
This pull request works towards this capability by adding a .devcontainer and .vscode settings.
.devcontainer
This can be leveraged when working in https://vscode.dev/ web-based IDE environment. However, creating the capability to to development completely requires organizations to sign up for GitHub Codespaces in their enterprise subscription.
Another potentially interesting option for MTC would be to configuring a local-server on a machine that has an Emme license.
.vscode
settings.json
As of now there are not a lot of project-specific settings that I could think of, but included a small handful.
extensions
Added a handful of useful ones as "recommended".
@lmz I leave it to you to decide if/when/how to integrate this PR - my guess is that it is most useful as you have staff working on this.
Applicable Issues
Addresses #20