migrate from OpenJDK to Zulu #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
force-pushed
the
java
branch
3 times, most recently
from
bea57f5
to
fe98338
Compare
izeigerman
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember we had to move to Zulu in LightGBM project due to changed license agreement and limited support. As we are now using our Docker at CI services (and possibly will produce artifacts from it) I think we should do the same.
To be honest, I'm far away from legal aspects of software development, but I believe we should use only things that are totally free and have no pitfalls.
Echoing myself from the past:
Azul Zulu
I can say that Zulu implementation looks quite stable as there have been no issues with it for more than one year in the LightGBM repo (guolinke/lightgbm-ci-docker#1).
Some refs:
https://azure.microsoft.com/en-us/blog/microsoft-and-azul-systems-bring-free-java-lts-support-to-azure/
https://habr.com/ru/post/448632/