update TFP code #220
Merged
update TFP code #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Since its crashing does @junpenglao need to run or verify chapter 6? |
|
That would be great. Alternatively, I can remove that notebook from this PR. Or do something else... |
|
IMO just add a note that says "this notebook is note completed" at the top and we can merge |
canyon289
reviewed
Dec 27, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter 6 (Times Series) keeps crashing on my machine, so I was not able to rerun the entire notebook
At some point the first cell of the notebook was changed to "markdown", instead of "code", I turned back to code and removed the message.
The environment file is also updated